Split up derive and make test assertions better #155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR works on our
sval_test
library to make it produce more useful messages when implementations ofValue
fail. AValue
shouldn't fail itself, similarly to the expectation onDebug
andDisplay
, but if it does we should make some effort to communicate why.I'm also splitting up
sval_derive
so that we can add extensions to it, like#[flatten]
, that might make use of other libraries likesval_buffer
orsval_fmt
.